Refactor modules: Remove hardcoded magical array size. #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AirlineData AnimalData BookData ColorData CommerceData CompanyData ComputerData Signed-off-by: AnkitGourav <[email protected]>
DatabaseData DateData FinanceData FoodData HackerData InternetData LocationData Signed-off-by: AnkitGourav <[email protected]>
LoremData MedicineData MovieData MusicData PersonData PhoneData PlantData Signed-off-by: AnkitGourav <[email protected]>
ScienceData SportData SystemData VideoGameData VehicleData WeatherData WordData Signed-off-by: AnkitGourav <[email protected]>
cieslarmichal
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded
std::arraysize magic number values and replace it withstd::to_arrayandautoto automatically find the size at compile time. Usingautofor type wont cause any issue as data type is defined withstd::to_array.This will make easier to add more data and expand the list, now there won't be any need to track no. of items in the list/array.